pytition / Pytition

Django app for self-hosted privacy-friendly online petitions
https://pytition.org
BSD 3-Clause "New" or "Revised" License
97 stars 28 forks source link

Show petition creation date on petition page #294

Closed fallen closed 1 year ago

fallen commented 1 year ago
rsk2 commented 1 year ago

Hi @fallen. I am interested in working on this issue, but first I wanted some help to understand it better. Can you please answer the following questions:

fallen commented 1 year ago

Hello @rsk2 thanks for your help on this :) It's much appreciated!

I would also:

Tell me what you think, and whether this is clear or not :)

rsk2 commented 1 year ago

Ok, thanks @fallen. Since this issue involves a lot of changes, is it fine if I break it into multiple pull requests with incremental changes? That will make the pull requests easier for you to review as well.

fallen commented 1 year ago

Yes good idea! :+1:

rsk2 commented 1 year ago
* allow the owner of the petition to edit those dates, to set them manually in case they are empty (if the petition was created before this feature existed) or if for instance they published/unpublished the petition several times and want to reset the date to some precise date.

Hi @fallen, on which page should I add the publication date so that it's value can be edited?

fallen commented 1 year ago

@rsk2 I would say on the petition edit page? The one where you edit all the petition texts and settings. The /petition/<int>/edit one.

rsk2 commented 1 year ago

@fallen, I have updated the PR

rsk2 commented 1 year ago

@fallen, please review the PR

fallen commented 1 year ago

Wow sorry I completely forgot about this PR, I'll try to do the review ASAP!

rsk2 commented 1 year ago

No problem @fallen

rsk2 commented 1 year ago

Hi @fallen, can we close this issue?

fallen commented 1 year ago

Yes @rsk2 it's all good, thanks a lot :)

rsk2 commented 1 year ago

Thank you @fallen :)