search

pytorch / botorch

Bayesian optimization in PyTorch
https://botorch.org/
MIT License
3.11k stars 406 forks source link

Implement MultiTaskDataset.__eq__ #2594

Closed saitcakmak closed 1 month ago

saitcakmak commented 1 month ago

Summary: Previously, this would fallback to SupervisedDataset.__eq__, which uses self.X for comparison. If the underlying datasets have heterogeneous feature sets, self.X errors out.

The new MultiTaskDataset.__eq__ resolves this issue by comparing the underlying datasets one by one.

Differential Revision: D64911436

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D64911436

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.98%. Comparing base (e7539db) to head (78887bc). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2594 +/- ## ======================================= Coverage 99.98% 99.98% ======================================= Files 196 196 Lines 17365 17367 +2 ======================================= + Hits 17363 17365 +2 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 1 month ago

This pull request has been merged in pytorch/botorch@9d37e905639e0d4983e52ce425306b8161760ee4.