pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
1.83k stars 299 forks source link

Update flatbuffers to v24.3.25 #3966

Closed dbort closed 3 months ago

dbort commented 3 months ago

See changes in https://github.com/google/flatbuffers/compare/v23.5.26...v24.3.25

We don't need anything specific from this newer version, but it's good to stay up-to-date to ensure we have the latest bug/security fixes.

This required updating the buck targets to match the latest source/header lists at https://github.com/google/flatbuffers/blob/v24.3.25/CMakeLists.txt#L121-L207

Test Plan: Followed the instructions at https://pytorch.org/executorch/main/getting-started-setup.html

buck2 build //examples/portable/executor_runner:executor_runner succeeds. This builds and runs flatc from buck as a side-effect.

pytorch-bot[bot] commented 3 months ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3966

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 6a6fd12bb1df8969442e746903d7eaf1673c7e21 with merge base d308fd51a1e6b98a158d0257a301edb6ddda7c48 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 3 months ago

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@dbort merged this pull request in pytorch/executorch@1345bc2c601271b968accdeec238b3c91226dbcd.