search

pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
1.83k stars 299 forks source link

Remove memory-format workaround for Arm backend #3981

Closed oscarandersson8218 closed 2 months ago

oscarandersson8218 commented 3 months ago

Remove temporary fix for memory format introduced in https://github.com/pytorch/executorch/pull/2371. The dim-order of each node is annotated in a pass. Also some refactoring of arm_backend.py.

pytorch-bot[bot] commented 3 months ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3981

Note: Links to docs will display an error until the docs builds have been completed.

:heavy_exclamation_mark: 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

:white_check_mark: No Failures

As of commit da256dc23d7024b81f32a5e6f30ce30404c8990f with merge base dd7fa6a9d2efcae4f876d1ed08147a0e82ff024d (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

digantdesai commented 2 months ago

I will take a look tomorrow.

facebook-github-bot commented 2 months ago

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai commented 2 months ago

So not clear to me if this is really making use of dim order utils? is this in preparation to that?

Yes this is the intermediate step. See convo on Slack - https://pytorch.slack.com/archives/C01FV3A914N/p1719838104994989?thread_ts=1718355881.095489&cid=C01FV3A914N

facebook-github-bot commented 2 months ago

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

@digantdesai merged this pull request in pytorch/executorch@d3c92de23f33fe58752e957c0a787a5b44c21191.