Add PFH in buck for FoA

pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch

https://pytorch.org/executorch/

Other

1.83k stars 299 forks source link

Add PFH in buck for FoA #3985

Closed lucylq closed 3 months ago

lucylq commented 3 months ago

Summary: See:

Seems to be a new requirement for FoA, where all buck targets owned by the app must be tagged with the product name. Codegen.bzl is included by third-parties and the libraries created 'belong' to the target app? So we add the feature name to the libraries constructed in codegen.

See failure: D58557891

Differential Revision: D58620058

pytorch-bot[bot] commented 3 months ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3985

:page_facing_up: Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 716e060e40890694f50c0f3e3aeed3c253f2bd9d with merge base 56914ec1576205176bcba7e11ef70b1536326b4c (): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D58620058

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D58620058

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D58620058

facebook-github-bot commented 3 months ago

This pull request has been merged in pytorch/executorch@bcabc3757bda66c86aea493ea1b59e37351206ad.