search

pytorch / serve

Serve, optimize and scale PyTorch models in production
https://pytorch.org/serve/
Apache License 2.0
4.22k stars 863 forks source link

allow python version=3.12 in docker script build_image.sh #3332

Open fabridamicelli opened 1 month ago

fabridamicelli commented 1 month ago

Description

Docker images are built using the script build_image.sh which takes the argument pythonversion. Currently only versions 3.8, 3.9, 3.10 and 3.11 are allowed. To the best of my knowledge there is no reason why we should not allow python 3.12 (please correct me if I am wrong). This PR extends that list to include 3.12.

PS: If it is indeed the case that we should not allow 3.12, then it would be great to update the readme for consistency (currently only specifies python >= 3.8)

Type of change

Feature/Issue validation/testing

fabridamicelli commented 4 weeks ago

Hi @mreso

any ideas/comments on this? :) Since python 3.8 has reached end-of-life and 3.13 was released, it'd be great to be able to bump the versions in the docker scripts. Thanks in advance F