search

pytorch / test-infra

This repository hosts code that supports the testing infrastructure for the PyTorch organization. For example, this repo hosts the logic to track disabled tests and slow tests, as well as our continuation integration jobs HUD/dashboard.
https://hud.pytorch.org/
Other
83 stars 83 forks source link

fix for the typescript code after upgrading to IMDSv2 #5848

Closed wdvr closed 1 month ago

wdvr commented 1 month ago

this is a follow up on PR #5783 that enabled IMDSv2. We're about to remove support for IMDSv1 on our AWS account globally

This is part of an effort to move all our calls across all pytorch repos to v2.

See also: https://github.com/pytorch/FBGEMM/pull/3297 https://github.com/pytorch/pytorch/pull/138286 https://github.com/pytorch/torchsnapshot/pull/180 https://github.com/pytorch/torchrec/pull/2532 https://github.com/pytorch/torcheval/pull/210

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **torchci** | ⬜️ Ignored ([Inspect](https://vercel.com/fbopensource/torchci/BkUAsCWtXQopDBYCxLzESnyShmvv)) | [Visit Preview](https://torchci-git-wdvr-imdsv2fix-fbopensource.vercel.app) | | Nov 1, 2024 8:13pm |
wdvr commented 1 month ago

So to answer your question @malfet:

this is a follow up of PR https://github.com/pytorch/test-infra/pull/5783 that updated to v2, but failed to deploy due to the js code not being committed (and being buggy).

The only options in EC2 are support for v1 AND v2, or only v2. v2 has been released in 2019. There is an effort ongoing to enforce v2 for all Meta's AWS accounts since the release of this: https://aws.amazon.com/about-aws/whats-new/2024/03/set-imdsv2-default-new-instance-launches/

This is part of an effort to move all our calls across all pytorch repos to v2.

See also: https://github.com/pytorch/FBGEMM/pull/3297 https://github.com/pytorch/pytorch/pull/138286 https://github.com/pytorch/torchsnapshot/pull/180 https://github.com/pytorch/torchrec/pull/2532 https://github.com/pytorch/torcheval/pull/210