pytorch / test-infra

This repository hosts code that supports the testing infrastructure for the PyTorch organization. For example, this repo hosts the logic to track disabled tests and slow tests, as well as our continuation integration jobs HUD/dashboard.
https://hud.pytorch.org/
Other
83 stars 83 forks source link

[HUD] Compress api/issues/[label] #5854

Closed clee2000 closed 1 month ago

clee2000 commented 1 month ago

To reduce warnings about API response for /api/issue/skipped exceeds 4MB. API Routes are meant to respond quickly. https://nextjs.org/docs/messages/api-routes-response-size-limit

Realistically most of these calls don't need the entire body, which is probably most of the size, but going through and finding all references is a task for another day

Checked that main HUD page still has buttons for "test is disabled" and "disable test"

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 11:20pm
clee2000 commented 1 month ago

After doing some comparisons in the chrome console, the neither the amount transferred over the network nor the resource size actually change, but the warning does go away, so I assume there is compression happening after next issues the warning? Additionally Vercel has a size limit of 4.5MB on response body, I don't know if this is compressed or uncompressed, but given that things relying on this information still gets shown, I guess we aren't hitting that limit