search

pytorch / torchchat

Run PyTorch LLMs locally on servers, desktop and mobile
BSD 3-Clause "New" or "Revised" License
3.4k stars 225 forks source link

Update install_requirements.sh #1310

Closed mikekgfb closed 1 month ago

mikekgfb commented 1 month ago

After #1305 removed dependence on torchvision, this PR drops torchvision installation as part of install_requirements.sh

pytorch-bot[bot] commented 1 month ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1310

Note: Links to docs will display an error until the docs builds have been completed.

:x: 24 New Failures, 1 Cancelled Job

As of commit 2905670f6213b317262c8c30abd5ae5c4b2d2286 with merge base 8c75754fade9d9d004b832ac2db5491338597b79 (image):

NEW FAILURES - The following jobs have failed:

* [pull / compile-gguf (macos-14)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753112215) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753112215)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / runner-aoti (macos-14-xlarge)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753114462) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753114462)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-cpu-aoti (aarch64, stories15M)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753125073) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753125073)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-cpu-aoti (x86_64, stories15M)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753124016) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753124016)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-cpu-compile (aarch64, stories15M)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753125751) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753125751)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-cpu-compile (x86_64, stories15M)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753124828) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753124828)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-cpu-eval-sanity-check (aarch64, stories15M)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753125287) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753125287)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-cpu-eval-sanity-check (x86_64, stories15M)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753124590) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753124590)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-cpu-eval-sanity-check-float16 (aarch64, stories15M)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753126000) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753126000)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-cpu-eval-sanity-check-float16 (x86_64, stories15M)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753125536) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753125536)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-cpu-eval-sanity-check-float32 (aarch64, stories15M)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753126650) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753126650)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-cpu-eval-sanity-check-float32 (x86_64, stories15M)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753126248) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753126248)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-gguf-util (macos-14)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753110157) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753110157)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / test-gpu-aoti-bfloat16 (cuda, stories15M) / linux-job](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753127679) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753127679)) `RuntimeError: Command docker exec -t 4b33947d7082f964f6a4b8e955ff29e4a421266c5f7b097864501c52c7e51c91 /exec failed with exit code 1` * [pull / test-gpu-aoti-float16 (cuda, stories15M) / linux-job](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753127954) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753127954)) `RuntimeError: Command docker exec -t a6d560ab98abab2bff28018dd901b470a523d8afa1754528f2449d74e84a3bab /exec failed with exit code 1` * [pull / test-gpu-aoti-float32 (cuda, stories15M) / linux-job](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753128200) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753128200)) `RuntimeError: Command docker exec -t 0ddc97252ac559db1dd890ff51f70f35aa0f55b467c8f3f31e78e0b16030c146 /exec failed with exit code 1` * [pull / test-gpu-compile (cuda, stories15M) / linux-job](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753128493) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753128493)) `RuntimeError: Command docker exec -t 55b80179dc84e699768ac2d9aa74e3302911b095def7486f117c46b9e79781a4 /exec failed with exit code 1` * [pull / test-gpu-eval-sanity-check (cuda, stories15M) / linux-job](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753128761) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753128761)) `RuntimeError: Command docker exec -t 94ac942648578dc21162afdc69d4f8c3a8d950f775378db902bb19a07a2fcb56 /exec failed with exit code 1` * [pull / test-mps (macos-m1-stable)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753111209) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753111209)) `ModuleNotFoundError: No module named 'torchvision'` * [pull / torchchat-command-load-test (macos-14)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753111489) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753111489)) `ModuleNotFoundError: No module named 'torchvision'` * [Run parallel prefill / test-cuda / linux-job](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753109483) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026857/job/31753109483)) `RuntimeError: Command docker exec -t ee2b95420a6aec43321cb72bd2386366291d6aafad174310c9649d8485053397 /exec failed with exit code 1` * [Run the aoti runner with CUDA using stories / test-runner-aot-cuda / linux-job](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753110104) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026864/job/31753110104)) `RuntimeError: Command docker exec -t eeb86eb28b5427d4277a070403818702ed5861a3705df35062e755b5169e2bdc /exec failed with exit code 1` * [Run the README instructions - with stories - on MPS/MacOS / test-advanced-mps-macos / macos-job](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753110105) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026852/job/31753110105)) `Library not loaded: @rpath/libarchive.19.dylib` * [Run the README instructions - with stories - on MPS/MacOS / test-quantization-mps-macos / macos-job](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753111500) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026852/job/31753111500)) `Library not loaded: @rpath/libarchive.19.dylib`

CANCELLED JOB - The following job was cancelled. Please retry:

* [pull / runner-aoti (16-core-ubuntu)](https://hud.pytorch.org/pr/pytorch/torchchat/1310#31753113314) ([gh](https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753113314))

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Jack-Khuu commented 1 month ago

Looks like torchtune is looking for torchvision, but isn't being pulled it in as part of tune itself: https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753111489?pr=1310

@ebsmothers Is this intended behavior or have we imported tune improperly?

mikekgfb commented 1 month ago

Never mind, we need torchvision for torchtune (and importing it transitively), so removing the only import of torchvision in model.py is not sufficient to be able to remove torchvision from the list of packages we depend on.