search

pytorch / torchchat

Run PyTorch LLMs locally on servers, desktop and mobile
BSD 3-Clause "New" or "Revised" License
3.4k stars 225 forks source link

Fix error: characters can not be displayed normally in chinese #1342

Closed wjunLu closed 3 weeks ago

wjunLu commented 3 weeks ago

Some Chinese characters require more than two or three tokens to decode, tokens will be decoded immediately, rather than wait for two or three tokens.

Current output: image

Fixed output: image

pytorch-bot[bot] commented 3 weeks ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1342

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 3b52e0edf3b4f671213a9ec070035df8f60594c5 with merge base 4a7dab8cfb7111aa2323ad840cda68d65b81e86f (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 3 weeks ago

Hi @wjunLu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Jack-Khuu commented 3 weeks ago

Thanks for the fix @wjunLu, just kicked off the CI

Jack-Khuu commented 3 weeks ago

@wjunLu PR lgtm, can you take a look at setting up your CLA? (Allows you to contribute to Facebook/Meta repos)

wjunLu commented 3 weeks ago

@wjunLu PR lgtm, can you take a look at setting up your CLA? (Allows you to contribute to Facebook/Meta repos)

I have signed CLA, how to re-check CLA?

Jack-Khuu commented 3 weeks ago

Just kicked off the CI again, once its good I'll merge

Thanks again!