pytr-org / pytr

Use TradeRepublic in terminal and mass download all documents
https://pypi.org/project/pytr/
MIT License
422 stars 74 forks source link

MINOR: Some files contain leading blanks, where than nextcloud complains, and hopefully small feature request #137

Open fft1010 opened 2 weeks ago

fft1010 commented 2 weeks ago

Description of the bug Some filenames contain occassionally leading blanks, which leads nextcloud to "complain", and it suggest a rename.

To Reproduce Just download. In my case it happened with "Transaktionsbestätigung", for an US stock. It happens rarely, I could not find a pattern. So I suggest to "sanitize" the filename "somehow". My beloved suggestion is below as a feature request.

Environment

Additional context I have a lot downloads, as I trade quite often. And I could not find a pattern when it happens. It occurs in a very rare case. If I would like to have a wish, I would like to suggest a more "fixed?" "static" filename like YYYY-MM-DD-HH-MM-SS-type-tr-transaction-number-description.pdf

where YYYY-MM-... is the transaction date/time as accurate as you can get it. It would help finding problems. "type" is "Abrechnung", "Basisinformationsblatt", ... "tr-transaction-number" looks like 047713ed-84c1-49a1-8331-e6c10e764ad5 which is added if I trade a stock twice or more a day it seems. It is missing the first time, but from than on it is added. "description" is e.g. "E.L.F. Beauty".

remove all leading blanks, and maybe trailing as well as you cannot "see" them really in the file listings. replace the test of the blanks with an underscore.

All in all as always: Many thanks for this great piece of software. I can't live without it!

thanks juergen