search

pytroll / pygac

A python package to read and calibrate NOAA and Metop AVHRR GAC and LAC data
https://pygac.readthedocs.org/
GNU General Public License v3.0
20 stars 25 forks source link

Switch to `pyproject.toml`entirely #126

Closed mraspaud closed 5 months ago

mraspaud commented 5 months ago

This PR drops setup.py and uses pyproject.toml only.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 74.22%. Comparing base (0cccee8) to head (a519397).

Files Patch % Lines
pygac/patmosx_coeff_reader.py 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #126 +/- ## ========================================== - Coverage 77.04% 74.22% -2.82% ========================================== Files 32 33 +1 Lines 3001 3115 +114 ========================================== Hits 2312 2312 - Misses 689 803 +114 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mraspaud commented 5 months ago

The documentation should be good as it is. I just need to double check the scripts before this can be merged.

sfinkens commented 5 months ago

You mean pygac-run? It's declared legacy in the documentation, so we could also remove it

mraspaud commented 5 months ago

You mean pygac-run? It's declared legacy in the documentation, so we could also remove it

ah, good to know. But there is also pygac-convert-patmosx-coefficients which I think is still used, right?

sfinkens commented 5 months ago

Oh right, we need that one

sfinkens commented 5 months ago

LGTM!