pytroll / pytroll-aapp-runner

Pytroll runner for AAPP
http://pytroll-aapp-runner.readthedocs.io/en/develop/
GNU General Public License v3.0
1 stars 8 forks source link

Change implicit relative import and add ana test #13

Closed gerritholl closed 3 years ago

gerritholl commented 3 years ago

Change an implicit to an explicit relative import in the ana runner and add a rudimentary unit test for the runner. Also replaced two calls to logger.error by logger.exception as it was printing insufficient information for the exception before.

ghost commented 3 years ago

DeepCode's analysis on #22d23d found:

Description Example fixes
Undefined variable 'breakpoint' Occurrences: :wrench: Example fixes
Either all return statements in a function should return an expression, or none of them should. Occurrences: :wrench: Example fixes
Use % formatting in logging functions and pass the % parameters as arguments Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

gerritholl commented 3 years ago

Can a member of @pytroll/core please assign @TAlonglong as a reviewer here?