Refactor tle handling - Githubissues

pytroll / pytroll-aapp-runner

Pytroll runner for AAPP

http://pytroll-aapp-runner.readthedocs.io/en/develop/

GNU General Public License v3.0

1 stars 8 forks source link

Refactor tle handling #20

Closed adybbroe closed 2 years ago

adybbroe commented 3 years ago

Re factor the TLE handling a bit and add option to fetch TLEs from an other local repository/directory (NFS or similar) and copy them into the AAPP data structure.

[ ] Closes #xxxx
[x] Tests added
[x] Tests passed: Passes pytest
[ ] Passes flake8
[ ] Fully documented

ghost commented 3 years ago

DeepCode's analysis on #c96da0 found:

:warning: 2 warnings :point_down:
Top issues

Description	Example fixes
Use os.makedirs instead of os.mkdir because the given path may require creating the parent directories. Occurrences: tle_satpos_prepare.py:202	:wrench: Example fixes
(BETA suggestion) Use of tempfile.mktemp is deprecated and poses a security risk Occurrences: tle_satpos_prepare.py:203	:wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

adybbroe commented 3 years ago

Not sure I can devote much more time at this. Not easy to make meaningful unittests to the TLE file handling!

mraspaud commented 3 years ago

Do you want us to review it now or do you plan on improving this later?

adybbroe commented 3 years ago

Ok, if I merge and close this one? I would like to try make a release of how it is now and then we can make new attempts to refactor and improve test coverage after that? @mraspaud @gerritholl ?

mraspaud commented 3 years ago

I haven't reviewed it yet

adybbroe commented 2 years ago

Many thanks for reviewing @mraspaud ! :-)