Closed KatrinPoepp closed 1 week ago
The branch for this PR includes 322 MiB in data (8 PNG files), added in commit 1367072ad008b7281f8ef94d8a72238d8d981b23. We should probably upload those files somewhere (zenodo?) and then include code to download them on-the-fly, as to not pollute the git repository with large binary files. This may need rewriting the commit history?
Yes, I think getting completely rid of the images from the repo requires rewriting the git history on force-pushing.
If we remove the images in a dedicated commit, then squash the commits before merge, would that be enough to remove the images from the git history?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.05%. Comparing base (
f3a2343
) to head (a326b11
). Report is 585 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
satpy/tests/utils.py | 2 | 93.16% | ||
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py | 3 | 98.67% | ||
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py | 3 | 97.18% | ||
<!-- | Total: | 8 | --> |
Totals | |
---|---|
Change from base Build 10957325874: | -0.01% |
Covered Lines: | 52493 |
Relevant Lines: | 54595 |
Starting to clone and test the repository pytroll/satpy
The testing process was executed successfully. See the test results for this pull request here!
Starting to clone and test the repository pytroll/satpy
A job is already running for this repository. Please wait for the current job to finish.
Starting to clone and test the repository pytroll/satpy
The testing process was executed successfully. See the test results for this pull request here!
The code under satpy/tests/behave/
is partially duplicated by https://github.com/pytroll/image-comparison-tests-dev/pull/2, for example:
and
Starting to clone and test the repository pytroll/satpy
A job is already running for this repository. Please wait for the current job to finish.
An error occurred during the process.
An error occurred during the process.
Error while cloning the repository: Error while cloning the repository: Command '['docker', 'run', '--name', 'clone-repo-image', '-v', '/home/imagetester/pull_request_pull-branch:/app', '-v', '/home/imagetester/pytroll-image-comparison-tests/data:/app/ext_data', 'python:3.10-slim', 'bash', '-c', 'touch /app/output.log && apt-get update >> /app/output.log 2>&1 && apt-get install -y git libgl1-mesa-glx libglib2.0-0 python3-venv >> /app/output.log 2>&1 && python3 -m venv /app/venv >> /app/output.log 2>&1 && /app/venv/bin/pip install behave Pillow pytest numpy opencv-python dask netcdf4 h5netcdf >> /app/output.log 2>&1 && git clone https://[REDACTED]@github.com/KatrinPoepp/satpy.git --branch pull-branch /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && pip install -e /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && cd /app/repository/satpy/tests/behave && behave >> /app/output.log 2>&1 || true && chown -R 1005:1005 /app >> /app/output.log 2>&1']' returned non-zero exit status 137.
Starting to clone and test the repository pytroll/satpy
The testing process was executed successfully. See the test results for this pull request here!
Replaced by https://github.com/pytroll/satpy/pull/2999
Pytroll image comparison dev behave tests as PR. This method of code transfer was proposed by Martin Raspaud. Documentation for the behave tests will be provided with the rest of the project code.