pytroll / satpy

Python package for earth-observing satellite data processing
http://satpy.readthedocs.org/en/latest/
GNU General Public License v3.0
1.08k stars 298 forks source link

add image comparison behave tests #2912

Closed KatrinPoepp closed 1 week ago

KatrinPoepp commented 2 months ago

Pytroll image comparison dev behave tests as PR. This method of code transfer was proposed by Martin Raspaud. Documentation for the behave tests will be provided with the rest of the project code.

gerritholl commented 1 month ago

The branch for this PR includes 322 MiB in data (8 PNG files), added in commit 1367072ad008b7281f8ef94d8a72238d8d981b23. We should probably upload those files somewhere (zenodo?) and then include code to download them on-the-fly, as to not pollute the git repository with large binary files. This may need rewriting the commit history?

pnuu commented 1 month ago

Yes, I think getting completely rid of the images from the repo requires rewriting the git history on force-pushing.

gerritholl commented 1 month ago

If we remove the images in a dedicated commit, then squash the commits before merge, would that be enough to remove the images from the git history?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.05%. Comparing base (f3a2343) to head (a326b11). Report is 585 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2912 +/- ## ========================================== + Coverage 95.97% 96.05% +0.07% ========================================== Files 368 373 +5 Lines 53973 54406 +433 ========================================== + Hits 51801 52259 +458 + Misses 2172 2147 -25 ``` | [Flag](https://app.codecov.io/gh/pytroll/satpy/pull/2912/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [behaviourtests](https://app.codecov.io/gh/pytroll/satpy/pull/2912/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `3.99% <ø> (-0.04%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/pytroll/satpy/pull/2912/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `96.14% <ø> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11075540122

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Files with Coverage Reduction New Missed Lines %
satpy/tests/utils.py 2 93.16%
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 3 98.67%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py 3 97.18%
<!-- Total: 8 -->
Totals Coverage Status
Change from base Build 10957325874: -0.01%
Covered Lines: 52493
Relevant Lines: 54595

💛 - Coveralls
gerritholl commented 3 weeks ago

Related to https://github.com/pytroll/image-comparison-tests-dev/pull/2

rymdulf commented 1 week ago

Starting to clone and test the repository pytroll/satpy

rymdulf commented 1 week ago

The testing process was executed successfully. See the test results for this pull request here!

rymdulf commented 1 week ago

Starting to clone and test the repository pytroll/satpy

rymdulf commented 1 week ago

A job is already running for this repository. Please wait for the current job to finish.

rymdulf commented 1 week ago

Starting to clone and test the repository pytroll/satpy

rymdulf commented 1 week ago

The testing process was executed successfully. See the test results for this pull request here!

gerritholl commented 1 week ago

The code under satpy/tests/behave/ is partially duplicated by https://github.com/pytroll/image-comparison-tests-dev/pull/2, for example:

https://github.com/pytroll/image-comparison-tests-dev/blob/106710d3534be8f326d67d3de358a9e210db80f1/behave/create_reference.py

and

https://github.com/KatrinPoepp/satpy/blob/ec4f99623642328f5eeab5691a035871501cd90f/satpy/tests/behave/create_reference.py

rymdulf commented 1 week ago

Starting to clone and test the repository pytroll/satpy

rymdulf commented 1 week ago

A job is already running for this repository. Please wait for the current job to finish.

rymdulf commented 1 week ago

An error occurred during the process.

rymdulf commented 1 week ago

An error occurred during the process.

rymdulf commented 1 week ago

Error while cloning the repository: Error while cloning the repository: Command '['docker', 'run', '--name', 'clone-repo-image', '-v', '/home/imagetester/pull_request_pull-branch:/app', '-v', '/home/imagetester/pytroll-image-comparison-tests/data:/app/ext_data', 'python:3.10-slim', 'bash', '-c', 'touch /app/output.log && apt-get update >> /app/output.log 2>&1 && apt-get install -y git libgl1-mesa-glx libglib2.0-0 python3-venv >> /app/output.log 2>&1 && python3 -m venv /app/venv >> /app/output.log 2>&1 && /app/venv/bin/pip install behave Pillow pytest numpy opencv-python dask netcdf4 h5netcdf >> /app/output.log 2>&1 && git clone https://[REDACTED]@github.com/KatrinPoepp/satpy.git --branch pull-branch /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && pip install -e /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && cd /app/repository/satpy/tests/behave && behave >> /app/output.log 2>&1 || true && chown -R 1005:1005 /app >> /app/output.log 2>&1']' returned non-zero exit status 137.

rymdulf commented 1 week ago

Starting to clone and test the repository pytroll/satpy

rymdulf commented 1 week ago

The testing process was executed successfully. See the test results for this pull request here!

gerritholl commented 1 week ago

Replaced by https://github.com/pytroll/satpy/pull/2999