pytroll / satpy

Python package for earth-observing satellite data processing
http://satpy.readthedocs.org/en/latest/
GNU General Public License v3.0
1.08k stars 298 forks source link

Drop python 3.9 #2936

Closed mraspaud closed 1 month ago

mraspaud commented 1 month ago

This PR drops support for python 3.9, as deemed reasonable in #2741. This superseeds #2741 which was difficult to merge with main. ~Also, we added an experimental build for python 3.13.~

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.09%. Comparing base (5634073) to head (f9dccad). Report is 77 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2936 +/- ## ======================================== Coverage 96.08% 96.09% ======================================== Files 375 377 +2 Lines 54615 55075 +460 ======================================== + Hits 52478 52925 +447 - Misses 2137 2150 +13 ``` | [Flag](https://app.codecov.io/gh/pytroll/satpy/pull/2936/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [behaviourtests](https://app.codecov.io/gh/pytroll/satpy/pull/2936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `3.95% <ø> (-0.04%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/pytroll/satpy/pull/2936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `96.19% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mraspaud commented 1 month ago

hmm, looks like the 3.13 experimental was a bad idea...

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11384578870

Details


Files with Coverage Reduction New Missed Lines %
satpy/readers/file_handlers.py 1 97.4%
satpy/readers/sgli_l1b.py 1 95.17%
satpy/readers/xmlformat.py 1 88.79%
satpy/tests/reader_tests/test_ahi_hsd.py 1 99.34%
satpy/readers/pmw_channels_definitions.py 2 96.41%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 11381112172: -0.01%
Covered Lines: 53169
Relevant Lines: 55268

💛 - Coveralls
djhoese commented 1 month ago

Were all the FCI/decomp requirements/requests related to dropping Python 3.9 resolved?

mraspaud commented 1 month ago

Yes I think so

mraspaud commented 1 month ago

The last comment on #2741 confirms it.