Prepare for channel-specific SEVIRI calibration

sfinkens commented 1 week ago

Prepare for channel-specific calibration (https://github.com/pytroll/satpy/issues/2599) by using satpy.readers.utils.CalibrationCoefficientPicker internally to select coefficients. No changes to public interfaces. Next steps in a future PR:

Add calib_wishlist reader kwarg
Deprecate calib_mode and ext_calib_coefs kwargs
Add calibration coefficients and mode to dataset metadata (https://github.com/pytroll/satpy/issues/2569). This is easier now, because CalibrationCoefficientPicker provides mode alongside coefficients.

[X] Tests added

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.09%. Comparing base (fa56be5) to head (5ab316e). Report is 9 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2997 +/- ## ======================================= Coverage 96.08% 96.09% ======================================= Files 377 377 Lines 55155 55231 +76 ======================================= + Hits 52997 53073 +76 Misses 2158 2158 ``` | [Flag](https://app.codecov.io/gh/pytroll/satpy/pull/2997/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [behaviourtests](https://app.codecov.io/gh/pytroll/satpy/pull/2997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `3.93% <0.00%> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/pytroll/satpy/pull/2997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `96.18% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 11970487783

Details

150 of 150 (100.0%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 96.198%

Totals
Change from base Build 11936881763:	0.005%
Covered Lines:	53317
Relevant Lines:	55424

💛 - Coveralls

sfinkens commented 1 week ago

Regarding the CodeScene issue about seviri_base.py being too complex: I could move the calibration parts into a separate file.

pytroll / satpy