pyure / infitech-prototype

The Infitech 3 Repo, codenamed Prototype
13 stars 13 forks source link

Performance drop with GT pump #517

Open TLaviron opened 5 years ago

TLaviron commented 5 years ago

Hello,

I have observed severe performance drops when using a GT pump (the machine, not the cover). I placed a pump over an oil source, powered by a battery buffer, and outputting oil into a Fancy Fluid Storage tank. I left the area (so the chunk should have been unloaded) and upon coming back the frame rate drops to 2FPS when the pump is in view. 2019-05-08_18 04 54 As the performance pie chart shows, a lot of time is spent rendering block entities. I assume those are supposed to be the pipes going down.

Breaking the pump restores normal framerate, but the pump and the battery buffer became transparent, even after being picked up and replaced: 2019-05-08_18 18 21

I did not notice anything wrong when placing the pump and staying around for a while, I don't know yet if it needs a long time away from the pump to notice performance drops, or if it can happen simply when the chunk is being reloaded after leaving, but I do know it happend twice at the same location.

TLaviron commented 5 years ago

Update : it turns that not just the pump and the battery buffer are no longer rendered, but a good number of gregtech blocks as well (and only gregtech). Disconnecting and reconnecting does not remove this, but relaunching the client does.

pyure commented 5 years ago

@TLaviron I've seen this happen when multiblocks span chunks, possibly in connection to forceloading those chunks. Any chance that's the case with your FFS? It seems to cause GT tile entities to corrupt.

TLaviron commented 5 years ago

Most likely, I think both pump locations had a tank spanning multiple chunks (unwise, but I only thought about checking for it after I built it...) I will try again with a tank in one chunk, and see if it still happens.

TLaviron commented 5 years ago

Update: with everything in a single chunk, there is still the performance drop but the corruption did not happen when I mined the pump this time. Since I just built some quantum tanks, I will try pumping into one and remove the FFS tank, and see what happens.

pyure commented 5 years ago

TLaviron, fwiw the Gas Lift is another pumping option if you can tolerate pneumaticraft (and possibly OP)