search

qaisjp / go-discord-irc

The Discord and IRC bridge with puppets! An IRC user is created for each Discord user, messages from IRC seamlessly appear on Discord, and Discord mentions are automagically converted to and from IRC.
MIT License
113 stars 32 forks source link

Cleanup: remove max_nick_length #109

Open llmII opened 3 years ago

llmII commented 3 years ago

This setting is no longer needed as the information can be gained via the listener at runtime. This changes things to use go-ircevent's ISUPPORT support instead of defining it in the config.

Closes #106.

This one will need some testing, creating a draft. Need to review and see if puppets are only created after the listener has processed OnWelcome or if it is possible they exist before in which case getting the value from ISUPPORT isn't possible since the listener doesn't exist yet...

qaisjp commented 3 years ago

Need to review and see if puppets are only created after the listener has processed OnWelcome or if it is possible they exist before in which case getting the value from ISUPPORT isn't possible since the listener doesn't exist yet...

It seems to work, but very good call on wanting to test this!

qaisjp commented 3 years ago

Did you manage to test whether ISUPPORT is fetched from the listener before connecting the puppets?