Wrong place for some I2P settings in advanced tab

[absolutep]

Suggestion

The following settings, i.e., tunnel configuration settings – should be below the i2p settings under Connections heading and not under advanced settings.

Why?

Tunnel configurations is a fundamental part of I2P torrenting which not only decides the security of i2p torrenting but also speed of i2p torrenting.

This setting should not be in ADAVANCED section

Instead, it should be under I2P settings in Connections Section

Use case

No response

Extra info/examples/attachments

No response

[thalieht]

@Vort @qbittorrent/bug-handlers any opinions about this? I want to add these settings to WebUI and i may as well do this too if you decide that it should happen (i have no opinion). If they are moved, the links to documentation will go away:

Configures the SAM session quantity of I2P inbound and outbound tunnels [1..16]. number of hops for I2P inbound and outbound tunnels [0..7] Changing these will not trigger a reconnect to the SAM bridge, they will take effect the next time the SAM connection is re-established (by restarting or changing i2p_hostname or i2p_port).

Maybe rename quantity -> tunnels and length -> hops? Unless you think the current names are descriptive enough / better. Also we'll need to add some form of the 2nd sentence as tooltip. And lastly, if the setting names are changed, should the API use them or use the libtorrent names (current names)?

[Vort]

any opinions about this? I want to add these settings to WebUI and i may as well do this too if you decide that it should happen (i have no opinion).

1. I saw users requesting I2P settings for WebUI, so I think it's a good idea to add them.
2. As for placement of quantity and length parameters: I think once users learn where parameters are located, it will be equally comfortable for them to navigate to appropriate place. Also I think that changing these parameters will be mostly needed during initial tweaking of client, so maybe it is even not important to memorize (users cand find, change and forget).

Maybe rename quantity -> tunnels and length -> hops? Unless you think the current names are descriptive enough / better.

I think no renaming is needed. However description may be changed to better describe meaning (if needed; it is fine for me now).

It is important to understand that these options are "dangerous". So it is better to have thier names matching SAM specification, to avoid confusion. Also this is how they are named in i2pd: Docs » User Guide » I2P tunnels configuration » I2CP parameters.

[thalieht]

Ok so quantity and length are actually official terms for I2P, didn't know that. I'll just add the settings to WebUI then.

[luzpaz]

Is it ok to assign this ticket to you @thalieht ?

[thalieht]

Is it ok to assign this ticket to you @thalieht ?

No, we decided not to move the settings. I'll just add them to WebUI.