search

qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.66k stars 4.01k forks source link

Kosovo flag hover showing n/a #20473

Open CDFER opened 9 months ago

CDFER commented 9 months ago

qBittorrent & operating system versions

Qt: 6.4.3 Libtorrent: 2.0.9.0 Boost: 1.83.0 OpenSSL: 1.1.1w zlib: 1.3

Edition Windows 11 Home 22H2 (10.0.22621) OS build 22621.3085

What is the problem?

image Kosovo flag hover showing n/a

Steps to reproduce

Find a Peer from Kosovo

Additional context

No response

Log(s) & preferences file(s)

No response

luzpaz commented 9 months ago

What version of Qbit ?

thalieht commented 9 months ago

Kosovo is not in ISO 3166-1 alpha-2 (yet?) even though DBIP recognizes it https://db-ip.com/faq.php

The country codes in our databases and API services are standard ISO 3166-1 alpha-2 codes with the addition of two non-standard codes : XK which is used by the European Commission, Switzerland, the Deutsche Bundesbank, SWIFT, and other organizations as a temporary country code for Kosovo

https://github.com/qbittorrent/qBittorrent/blob/0114610a40e3cc63613baa406f330107385a1626/src/base/net/geoipmanager.cpp#L149-L152

Adding Waiting upstream label until it's added to the list or someone decides that // Officially assigned need not apply anymore.