qbittorrent / qBittorrent

qBittorrent BitTorrent client
https://www.qbittorrent.org
Other
28.62k stars 4.01k forks source link

Force Recheck #3449

Closed DTG123 closed 8 years ago

DTG123 commented 9 years ago

I moved to QT from another client, and am trying to move a large torrent (349gb) that was 60% done in the other client. I reloaded the .torrent to start downloading again, set folder to the previous downloaded location, then did Force recheck. I got nothing, no notification that it was checking and no response that it found the completed files. I am assuming that any partial files will be useless and i can delete them knowing full well I have to download the entire file in QT.

The problem is force Recheck doesnt appear to be doing its job. Or I am doing something wrong here.

sledgehammer999 commented 9 years ago

Are you downloading something else that is higher in the queue? NOTE: There isn't a progress feedback from libtorrent when doing a recheck. Do you see HDD activity?

DTG123 commented 9 years ago

"Are you downloading something else that is higher in the queue?"

Couple times Yes couples times No, the torrent downloaded was about 20-25% complete, meaning whole complete files that were downloaded. Any files left over from the uT client (.!ut appended) were deleted so QT could take over. So I assumed by loading the torrent in QT, QT would see the completed files and download the rest no problem, but the progress bar shows 0% and doesnt recognize (it appears) the whole files that are already there.

"Do you see HDD activity?"

No I did not notice HDD activity. Sometimes with no indication of file recheck I would just close QT. So, I suggest adding an indicator/animation/window/tooltip to show that its rechecking files and/or not let QT close while a file check is in progress.

sledgehammer999 commented 9 years ago

Remove the torrent from the list. Install the 3.3.0alpha build: http://www.fosshub.com/qBittorrent.html Add it again it should work now.

3.3.0 has done a lot of stuff in improving operability with paths.

Does it work now?

DTG123 commented 9 years ago

Updated to the alpha build.

Made sure the HD lite was on for the new torrent, set location, it did a check of files but still doesnt recognize the file already there, shows as Not downloaded.

  1. unchecked anything not downloaded and selected 7 complete files that are there, recheck seems to take forever for 7 files. When recheck did complete, still shows files as 0.0%. Note: I think Priority column should say "skipped" or "ignored", anything instead of "not downloaded", just IMO. Looking at folder locations in Options, I set incomplete torrents in a separate folder than completed torrents as usual. The problem I see seems to be that Qt is still downloading to "keep incomplete torrents in:" (d:\torrents incomplete) even after the "set location" is pointed to another folder, "d:\torrents done" in this case.

So..................

  1. I deleted the file folder that Qt put in "d:\torrents incomplete" folder and Qt wont recheck (scan) the torrent at all.
  2. copied the entire downloaded folder into partial completed torrent to that folder 3 deleted old torrent again.
  3. starting the torrent again, pointed to the d:\torrents done location, the recheck scan seems to be ignoring that folder and checked the d:\torrents incomplete instead, the good news is that it resulted in a proper file re-check and proper completion percentage of current download in progress.
  4. If a completed file is unchecked from the file download list, its shown at 0.0% even though its there and complete.
  5. if I uncheck all files from the download list, QT marks the whole torrent at complete and properly moves the whole folder and contents to the finished torrents folder. This is good.
  6. do a Force Recheck, with 1 incomplete file selected, makes the scan take way too long, over 1 minute or more. 7a. This resulted in all the files and folders back in "d:\torrents complete" folder, it copied it back?
  7. another Force Recheck scan with no files selected takes a long time, and shows the torrent at 0.0%, like nothing at all has been downloaded.
  8. Right click menu, "Set Location" is not the same as "Open destination folder", it should be. I should have check this as soon at the new torrent was loaded. I didnt.

:) Glad to help.

seanvolt commented 9 years ago

I have the same problem. I believe it's the same glitch as mentioned in these two threads. https://github.com/qbittorrent/qBittorrent/issues/165 https://github.com/qbittorrent/qBittorrent/issues/283 My particular case, I manually moved a torrent to a different location, "Set Location" on the torrent, and did a recheck. 0%. Clicking "Open destination folder" takes me to my incompleted torrents directory. I even tried unselecting "append the label of the torrent to the save path." Same result, except "open destination folder" takes me to my completed torrents directory.... All the while "Set Location" opens up to the folder I previously selected.

DTG123 commented 9 years ago

3 years wow.

DTG123 commented 9 years ago

Ok nothing here in 10 days.

How about this for the next iteration, just remove the Set Location function from the right click menu. If it doesnt work as intended, no sense keeping it in. However, the right click function "Open Destination Folder" should be changed to Open File/Folder Location. Which is what it does anyway.

The way QT handles completed and torrents that only a few files were checked to be download, is that when those few files are complete, it tells QT the whole torrent is done and moves the completed torrent to the Completed Torrents folder. If a few more files are selected to be downloaded later on, QT moves the entire folder back to the Incomplete Torrents folder. A genuine waste of energy and hard drive activity is thru the roof. If someone sets separate HDD locations for Complete and Incomplete folders, QT will appear frozen/slow to respond at times. If people are using an SSD to download to, omfg, talk a short life span.

i think its important to get those folder pointer locations fixed more than adding any new features.

DTG123 commented 9 years ago

I see no new client updates. Guess this wont get fixed anytime this year...

chrishirst commented 9 years ago

The problem is force Recheck doesnt appear to be doing its job. Or I am doing something wrong here.

Did you remove any .!ut extensions before rechecking???

DTG123 commented 9 years ago

LOL. Please read the thread.

linux-modder commented 9 years ago

3.3.0beta is in git if you feel comfy with git building

Corey W Sheldon Freelance IT Consultant, Multi-Discipline Tutor Ameridea LLC, Co-Founder, CTO Fedora Ambassador, North America (p) +1 (310) 909-7672

"Have no way as way, no limitation as limitation. One must never

underestimate the power of boredom...from which creativity and laziness are borne, which can spark great works of chaos and genius."

Find Me on any of the sites I teach /frequent:

https://gist.github.com/linux-modder/ac5dc6fa211315c633c9

Tox: corey84@toxme.se 9357BC6A5944A08AFC7D1EFFD61F6A73B9EABF8B2FB84ACF1DAC9A1A4D0A4705FFCCD0E5499B PGP: 718BF597 http://pgp.mit.edu/pks/lookup?op=get&search=0xE958C5D6718BF597 FP: 2930

99EB 083D D332 0752 88C4 E958 C5D6 718B F597

On Sat, Aug 15, 2015 at 4:18 AM, Chris Hirst notifications@github.com wrote:

The problem is force Recheck doesnt appear to be doing its job. Or I am doing something wrong here.

Did you remove any .!ut extensions before rechecking???

— Reply to this email directly or view it on GitHub https://github.com/qbittorrent/qBittorrent/issues/3449#issuecomment-131314606 .

DTG123 commented 9 years ago

3.3alpha is what im using.

chrishirst commented 9 years ago

Please read the thread.

It says you deleted some files (which I don't understand why) but it does not say whether you removed any other extensions.

DTG123 commented 9 years ago

It says you deleted some files (which I don't understand why) but it does not say whether you removed any other extensions.

I dont understand what you dont understand.... I thought I explained clearly enough a child could understand, I guess I was wrong.

!ut is a uTorrent partial file extension, any files left over from Utorrent got deleted, its not that hard to figure out QT uses !qt and a good guess that just changing the the file extension wont work. So ya I deleted "some" files, with the !ut extension.

linux-modder commented 9 years ago

The extension is a moot point the data inside the file is still useable changing the !ut to !qt and rechecking would have done the trick.

DTG123 commented 9 years ago

shoulda, woulda, coulda. Its all hindsight now. Not like that bit of info was in plainsight during setup, even if it was, I dont think it would have changed the issues I was having.

chrishirst commented 9 years ago

The extension is a moot point the data inside the file is still useable changing the !ut to !qt and rechecking would have done the trick.

Or simply removing it.

even if it was, I dont think it would have changed the issues I was having.

Maybe not, the issue you were having is probably because you pointed qBT to the wrong folder OR left the uTorrent created sub folder in place so qBT could not locate the actual payload.

DTG123 commented 9 years ago

You dont know what you are talking about. Have you even used uT? Please explain how uTorrent creates and uses subfolders, cuz i dont think you know.

i didnt point to a wrong folder.....

omfg..

sledgehammer999 commented 9 years ago

@chrishirst you're complicating matters here without adding something substantial. Please refrain from commenting. @DTG123 there are beta buids available on the forum (and fosshub.com). The update mechanism doesn't work on non-stable builds. Care to try again? I know that I am not focusing but there are so many things happening at once, I just can't be there 24x7. Sorry.

linux-modder commented 9 years ago

@sledgehammer999 , If there is anything I can help with (especially testing wise) please let me know. I love qbittorrent and have had to work through some rough patches both with apps and RL lately but can surely help.

sledgehammer999 commented 9 years ago

@linux-modder if you're a programmer try to fix issues that are already open (or implement requests) by making Pull Requests for merging. If not, try to triage bugs, but be sure that you know what you're talking about or how qbittorrent should behave. I don't want endless and unhelpful suggestions that bloat issue reports( comment-wise)

DTG123 commented 9 years ago

@sledgehammer999 I have the alpha build (3.3.0), is that the latest build?

But, if you think changing to a beta build would be any different please point the way there.

sledgehammer999 commented 9 years ago

beta builds are always after alpha builds. Download latest from here: http://www.fosshub.com/qBittorrent.html

DTG123 commented 9 years ago

Finally it did it again, the torrent was over 75% done. Appears to happen when there are more than 20-25 files and multiple folders and sub-folders.

I dont let QT run all night, so I paused the torrent and closed QT. Later, I started another torrent download and having forgot about the prior torrent. After the new torrent was complete I restarted the first one again. Imagine my facepalm moment when I saw it was downloading the entire torrent from 0%. Again tried to set download location to the complete folder location, and again, QT failed to recognize what has been completed already after using Force Re-check and Set Location

I feel bad for anyone in the UK, or anywhere, with download limits (pay by MB over cap) is purely f***ed by this. It makes me wonder why I quit using uTorrent to begin with, then I remember, its because of ads and bloat.

chrishirst commented 9 years ago

I feel bad for anyone in the UK, or anywhere

It does not happen to me at all.

Appears to happen when there are more than 20-25 files and multiple folders and sub-folders.

No. It will happen when you do NOT allow sufficient time for all qbittorrent/libtorrent processes to STOP before closing the host machine down. The more pieces are actively downloading, the longer it WILL take to be in a 'safe' state for shut down. Even when you pause tasks first, you HAVE to wait for ALL activity to cease and the cached pieces to be committed to disc before closing the machine down.

If you are 'serious' about 'torrenting' your machine should be on permanently, and all shut downs should be planned.

DTG123 commented 9 years ago

If I have to "allow sufficient time" for QT to do something, there is something very wrong with it. Obviously, there is a problem with the code if just exiting a program screws up everything with a minor issue such as this that the developers cant seem to fix. I never ever, ever, had such a problem with uTorrent.

To be clear, if by Host Machine, you mean my PC then no, my PC never gets shut down except for windows update reboot, I have no idea what nether region you pulled the idea that I shutdown my PC from, is thin air maybe? Only QT gets exited with this issue. TBH, it appears random because I open and close QT several times a day, I can not force this issue to happen and it didnt happen again since reporting this issue on the last large torrent, the torrent I start this issue with.

If QT does not check both folders (incomplete and complete), then it will never know what has been downloaded. That data should be saved and amended to the torrent file when it is moved to the completed torrents folder. Which raises another question, how can the torrent file be sent to the completed torrents folder if the [incomplete] torrent file in the stored torrents folder is still there? The answer is, someone missed a step here or there is more than 1 answer path in the flow chart.

I also wonder if this issue is related to Append !qB (options check box). I have a blank for a Watched Folder, and QT doesnt have any FAQs or instructions how to use that specific feature. (I wont preallocate files either.)

chrishirst commented 9 years ago

If I have to "allow sufficient time" for QT to do something, there is something very wrong with it.

No it isn't, it means that it is trying to preserve data as much as possible

What would you prefer?

A: All the downloaded pieces that are still cached to be abandoned and therefore wasted, at close down. or B: To commit all the cached pieces to disc before closing (this takes time)

Of course you can avoid a long close down, by: Having fewer active downloads (5 or less) A smaller cache (10 MiB or less) Fewer connections per torrent (10 or less) Fewer global connections (50 or less)

Or maybe even run your bittorrent client as they are intended to be operated, and that is on, continuously.

DTG123 commented 9 years ago

"No it isn't, it means that it is trying to preserve data as much as possible"

Yes it does. This is something that can be programmed into ANY program where the developer isnt being lazy. The onus for preserving data should never be trusted to the user. How would you like it Windows didnt save changes to the registry randomly when it shuts down because you didnt open regedit and export settings to preserve the data? This issue no different then using a backup program. QT is moving completed portions of a torrent before its completely done. then moving those files back when that torrent is unpaused to download the rest of the file in that torrent. I cant force a torrent to start downloading until that step is completed. Its not my fault how QT handles commands even if this process is handled wrong. There is a certain common sense that needs to be applied to QT, and using a flow chart would help debug the process of stopping and restarting torrents since that is obviously flawed here.

A is exactly what is happening here. B is the same as pre-allocating.

close down should be part of the program integrity, not me. I only do 1 active download at a time, all of my shitty bandwidth to 1 torrent at a time for obvious reasons. I dont see a setting for cache size, so only set connection limits as suggested and will report back next time. I doubt these settings have anything to do with this issue.

sledgehammer999 commented 8 years ago

I am lost again. @DTG123 can you tell me if this is still happening? If not, please close this. If yes, can you sum up the behavior/problem/bug in simple steps? PS: Latest is v3.3.3