search

qca / open-ath9k-htc-firmware

The firmware for QCA AR7010/AR9271 802.11n USB NICs
Other
428 stars 182 forks source link

xretries on broadcast frames #96

Open DC-fgervais opened 7 years ago

DC-fgervais commented 7 years ago

It looks like the ar5416 only has the AR_ExcessiveRetries flag to let the outside know it didn't receive an ACK. This is a bit weird for broadcast/multicast frames because it gets set even though it's not "excessive retry" per se but so be it.

However, I would be in favor of incrementing the excessive retry statistic (sc_tx_stats.ast_tx_xretries) only when we indeed reached the retry limit for a unicast frame.

I think this would make the kernel debugfs tgt_tx_stats a bit more usefull.

I'd be happy to send a pull request for a patch if we agree.

erikarn commented 7 years ago

Yes, that is fine!

-a

On 21 September 2016 at 12:01, Francois Gervais notifications@github.com wrote:

It looks like the ar5416 only has the AR_ExcessiveRetries flag to let the outside know it didn't receive an ACK. This is a bit weird for broadcast/multicast frames because it get set even though it's not "excessive retry" per se but so be it.

However, I would be in favor of incrementing the excessive retry statistic (sc_tx_stats.ast_tx_xretries) only when we indeed reached the retry limit for a unicast frame.

I think this would make the kernel debugfs tgt_tx_stats a bit more usefull.

I'd be happy to send a pull request for a patch if we agree.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/qca/open-ath9k-htc-firmware/issues/96, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGl7bi87hDrXgyOgLWXwKblMvuUTI7Jks5qsX8GgaJpZM4KDKSG .