Make on-screen Product Name "Data Curator"

qcif / data-curator

Data Curator - share usable open data

MIT License

266 stars 38 forks source link

Make on-screen Product Name "Data Curator" #132

Open Stephen-Gates opened 7 years ago

Stephen-Gates commented 7 years ago

Replacing PR #120

Expected Behaviour (for problems)

Application name appears on-screen as "Data Curator"

Current Behaviour

Some UI elements show "DataCurator" a set in package.json

Your Environment

Data Curator version 0.3.4
Operating System macOS High Sierra 10.13

Stephen-Gates commented 7 years ago

Still present in 0.5.4

ghost commented 6 years ago

Hi @Stephen-Gates It's been a while, but originally I think there might have been an issue with downloading a url with spaces from github - not sure, so I'll update productName to have space for mac and windows build and then, I'll have to do an minor version build first to test and if it doesn't work look at adding a shell script step that changes the name of the zip package (not the internal application) to allow for download.

ghost commented 6 years ago

Hi @Stephen-Gates Despite, the build failing, the artifacts were published -so will check shortly. It think the build reported a fail as the change in archive name (removing spaces -while trying to preserve the new product with spaces internally) is different to the blockmap files (possibly used like a checksum) - will update these files too for next build as see if it helps.

ghost commented 6 years ago

Nope :( Intermediary step does not seem to have worked, will have to try a different approach.

Stephen-Gates commented 6 years ago

Problem remains in 0.17.0