Docker-Compose for Private-internet-access needs modification

[overlordian]

URL to the Wiki page

https://github.com/qdm12/gluetun-wiki/blob/main/setup/providers/private-internet-access.md

What's incorrect?

Docker-Compose section of the providers page for Private-internet-access does not work as is and should be modified.

volumes:

• gluetun:/gluetun

  Appears to be incorrect syntax for docker-compose does not work as is... suggest adding " ./ " by changing to:

volumes:

• ./gluetun:/gluetun

[Wobak]

You can actually do it with gluetun:/gluetun

You just have to declare the volume in the volumes section of the compose file

[overlordian]

Fair...and correct.... You can declare a glutun volume

I am more concerned with your documentation for people who don't know how to make this docker compse file work. If none of your other provider documents declare volumes...I wouldn't expect people to think they need to declare one for PIA. Questions can come up of whether or not you need a volume for this particular provider...which in some cases that is true. So does PIA, it doesn't seem so, no certs file needed. This just looks like a typo from that perspective. So if the intent is to have fully functional copyable documentation... Then I suggest changing your documentation. Either add a declared volume or just make the change suggested...or just remove...

I am more concerned with people thinking your documentation is complete. Please, if that is your intention update your documentation. I would hate to have people get frustrated and not use your container if they can't debug on their own or start questioning their sanity against your intent through your documentation.

Thanks for the quick response last night.

[Wobak]

Apologies I'm not part of the gluetun dev team, I was just parsing issues and figured that if people were to hit the issue, they could have both solutions : replacing with a local volume with ./ or declaring a volume properly in their compose.

I agree with you that the doc should be updated, I'm guessing it's a easy PR to do on the wiki repo if you want to do that :)

[overlordian]

No worries, I shouldn't have assumed you were with the project and just trying to help, thank you for that by the way. Any way you cut it, you're correct... I actually didn't think about performing PR and just fixing it myself... I haven't done that before but I'll look into it and see if I can just handle this for folks. Thanks for responding....and I am sorry for jumping down your throat about it...we had the same goal here...I just didn't recognize you friend.

[Wobak]

Absolutely no offense taken don't sweat it too much.

I think the good point about making the wiki as a separate repo is for easy management. You fork the repo, do the modification in the doc, commit it, and then do a PR explaining what you changed and why.

Should be quite easily done :) Good luck !

[qdm12]

Hi @overlordian you are totally correct and thank you for reporting this! I even saw this a few minutes ago (I'm currently going through all wiki issues) and was wondering what the hell that bind mount declaration was 😄 And also thanks @Wobak for your input, it's always appreciated to have people commenting around on issues not of their own. Not all heroes wear capes 🦸 !

This is obviously fixed in afbb9dc4580544f0c7e18d811f79181ec38571fa

[github-actions[bot]]

Closed issues are NOT monitored, so commenting here will NOT be seen by the maintainer. If you think this is still unresolved and have more information to bring, please create another issue.

This is an automated comment setup because @qdm12 is the sole maintainer of this project which became too popular to monitor closed issues for additional comments.