search

qedus / osmpbf

OpenStreetMap PBF file format parser in Go Lang.
MIT License
141 stars 29 forks source link

Added support for Info to Node,Way and Relation #8

Closed Logician closed 9 years ago

Logician commented 9 years ago

Hi, I have added the Info struct to the parser.

The only thing that is not implemented is being able to tell if the original file had the optional values of the Info struct, but you could infer that from the default values being zero initialized. And it was ambiguous anyway between the DenseNodes and the other structs, where the DenseInfos does not have a per item way to tell whether the optional value was filled in or not, but only for the whole set.

Let me know your thoughts, thanks.

jongillham commented 9 years ago

Sorry it took so long. I didn't see your request. This looks great – thanks!

On visual inspection I see the variable user_sid is not canonical Go. Would you mind changing it to something like userSID?

Also I just merged in a change to update the protocol buffers location. Maybe you can merge your pull request to the tip to get this change as well?

Logician commented 9 years ago

I have merged the change and changed the variable naming. I'm not sure if this is automatically part of this pull request now, I've never done this before :)

jongillham commented 9 years ago

Thanks for the contribution!