qiboteam / qibo

A framework for quantum computing
https://qibo.science
Apache License 2.0
287 stars 58 forks source link

Fix transpiler bugs about moved measurements and duplicated gates #1369

Closed Simone-Bordoni closed 3 months ago

Simone-Bordoni commented 3 months ago

Solve bugs in #1363 and #1318

Checklist:

Simone-Bordoni commented 3 months ago

@BrunoLiegiBastonLiegi I have solved the bug reported in #1363. I will try to rapidly fix the Issue in #1318, in the meantime you can start the review of this part (I was not reardering the initial qubit map and this created some issues with the random placer). I have also added the seed for the random placer

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.84%. Comparing base (88825fa) to head (d78b626).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1369 +/- ## ======================================= Coverage 99.84% 99.84% ======================================= Files 75 75 Lines 10799 10807 +8 ======================================= + Hits 10782 10790 +8 Misses 17 17 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibo/pull/1369/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibo/pull/1369/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `99.84% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

renatomello commented 3 months ago

@Simone-Bordoni Can the PR name be more descriptive?