search

qiime2 / docs

https://docs.qiime2.org
BSD 3-Clause "New" or "Revised" License
21 stars 58 forks source link

IMP: ANCOM -> ANCOM-BC tutorial updates #569

Closed lizgehret closed 8 months ago

lizgehret commented 9 months ago

Replaces ancom with ancombc in PD Mice and Moving Pictures tutorials.

gregcaporaso commented 8 months ago

@lizgehret, this looks great!

I made a few little edits in the most recent commit. 1) "Why?" -> "Why might you expect this?" in the moving pics docs. Since it's not necessarily the case that there would be fewer differentially abundant genera than ASVs, I just felt like "Why might..." was a better way to ask this question. 2) 'donor + genotype' -> 'donor * genotype' - this aligns with how we run the anova earlier in the tutorial, and makes sense because donor and genotype could interact (apologies if I previously suggested using + here).

Also, in the multiple interfaces moving pictures tutorial, the filtering command is rendering strangely: Screenshot 2024-01-12 at 11 48 36 AM

If you're good with my edits, this is good to merge once we get that rendering issue sorted out.

lizgehret commented 8 months ago

Thanks @gregcaporaso! Oh yeah, that does look weird - I'll render locally and see what's going on there!

lizgehret commented 8 months ago

If you're good with my edits, this is good to merge once we get that rendering issue sorted out.

Okay, so for posterity - this has been fixed, and now looks reasonable when rendered locally: Screen Shot 2024-01-17 at 1 20 29 PM

Once this passes on CI, I'll go ahead and merge. Thanks for the review @gregcaporaso!

gregcaporaso commented 8 months ago

Thanks @lizgehret!