search

qiime2 / q2-deblur

BSD 3-Clause "New" or "Revised" License
2 stars 22 forks source link

Updating numpy and scipy dependencies #74

Closed mortonjt closed 5 years ago

mortonjt commented 5 years ago

This updates numpy and scipy dependencies. Mainly, I want to see what errors pop up if we bump up the version numbers

Addresses #68

thermokarst commented 5 years ago

Hey @mortonjt, this won't change the version of numpy included in the environment file, because there is still the version pin in scikit-bio.

mortonjt commented 5 years ago

yep - new changelog is posted here: https://github.com/biocore/scikit-bio/pull/1643/files

Am ready to push out new release on que

mortonjt commented 5 years ago

Hi @thermokarst , just as a heads up - scikit-bio has been updated! Do you think we can bump up the pin to scikit-bio=0.5.5? Thanks!

thermokarst commented 5 years ago

Thanks @mortonjt, this was addressed in https://github.com/qiime2/q2-deblur/pull/76 (a slightly more comprehensive effort that also involved upgrading to python 3.6). Thanks!

mortonjt commented 5 years ago

Awesome!

On Wed, Jan 23, 2019, 11:43 AM Matthew Dillon <notifications@github.com wrote:

Closed #74 https://github.com/qiime2/q2-deblur/pull/74.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/qiime2/q2-deblur/pull/74#event-2092203908, or mute the thread https://github.com/notifications/unsubscribe-auth/AD_a3Zak-hPdTBXxgPzgpnFyUuWVLMgIks5vGJEqgaJpZM4ZHHUC .