search

qiime2 / q2-vizard

The first choice of wizard lizards for interactive, generalized microbiome data visualization!
BSD 3-Clause "New" or "Revised" License
1 stars 9 forks source link

ENH: scatterplot-2d: Enable Zoom In/Out and Dynamic Resizing of Plot #35

Open ChristosMatzoros opened 2 months ago

ChristosMatzoros commented 2 months ago

This PR provides a solution for the enhancement described in issue #34.

It introduces zoom functionality, allowing users to zoom in and out based on the cursor's position. Additionally, the plot automatically resizes based on the window size, improving usability and preventing unnecessary scrolling.

lizgehret commented 2 months ago

Hey @ChristosMatzoros,

Thanks for submitting this PR! I did some user testing, and I think this all works quite well. A couple of things:

  1. I'm going to push up some name changes to the signals and scales you've added into the spec so that everything matches with the rest of my naming structures in vizard.
  2. I'd like to ask that you move the functionality for the auto resizing to a separate PR - I think this is awesome, and is definitely something I'd like to have in all of the visualizations, but realistically I'll need to add that in post-2024.10. I don't want this to just be something that's available in one visualization, but not all of them - and need to prioritize finishing up the core functionality in vizard for its initial release.

Thanks again for these contributions, let me know if you have any questions!