search

qiskit-community / qiskit-quantinuum-provider

Qiskit provider for Quantinuum backends.
Apache License 2.0
21 stars 17 forks source link

Using pytket backend for authentication calls #24

Closed chris-theroux closed 1 year ago

chris-theroux commented 1 year ago

Summary

Using the Quantinuum Pytket library for authentication calls. Still making use of Qiskit credential storage for tokens / user information.

Details and comments

This is the first of a few major changes we are making. The goal is to replace all API calls with the Pytket implementation. Please let me know if any of these changes are in conflict with Qiskit's design.

chris-theroux commented 1 year ago

Working on fixing py3.6 build error.

chris-theroux commented 1 year ago

@mtreinish is this an error on my side? Version 3.6 was not found in the local cache Error: Version 3.6 with arch x64 not found The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

chris-theroux commented 1 year ago

Removed python 3.6 support and updated the examples notebook.

mtreinish commented 1 year ago

I apologize, I was on vacation at the end of the year when you opened this and it completely slipped through the cracks. I took a quick look and the failures are primarily because of the tox 4.0.0 package release (which was incompatible with earlier version). Let me push up a Pr to get CI happy and then I'll rebase this for you.

mtreinish commented 1 year ago

Looks like we'll have to drop 3.7 support too: https://github.com/qiskit-community/qiskit-quantinuum-provider/actions/runs/4564705714/jobs/8054817824#step:6:23 it looks like pytket-quantinuum>=0.9 is only Python>=3.8. Let me make that change locally. Assuming CI passes with that change made this LGTM.

mtreinish commented 1 year ago

I went ahead and merged this, we can fix the tests later if needed.

chris-theroux commented 1 year ago

Hey @mtreinish, getting back to this project as well. Going to take a look at the test failures and double check that login is still working w/ the new version