search

qmhc / grid-layout-plus

A draggable and resizable grid layout, for Vue 3.
https://grid-layout-plus.netlify.app/
MIT License
325 stars 40 forks source link

Removed wrong saving of layout #12

Open filippo-biondi opened 1 year ago

filippo-biondi commented 1 year ago

Removed a saving of layout in responsiveGridLayout(). The saving was happening before findOrGenerateResponsiveLayout and this caused the originalLayout to be saved as layout for the current breakpoint. This caused some plots to overlap if the number of column in the originalLayout was bigger than the number of columns allowed by the current breakpoint. Furthermore the layout is correctly saved after findOrGenerateResponsiveLayout so I think the efficency is unaltered

netlify[bot] commented 1 year ago

Deploy Preview for grid-layout-plus ready!

Name Link
Latest commit 4991ac7f8ab6517368162cb8a14683defd1c4392
Latest deploy log https://app.netlify.com/sites/grid-layout-plus/deploys/654d25be8a415e000808e687
Deploy Preview https://deploy-preview-12--grid-layout-plus.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nastita commented 3 months ago

@filippo-biondi does this fix the overlaps when using responsive?

At least in the deployed netlify version it doesn't seem so.

SCR-20240815-jnpf
filippo-biondi commented 3 months ago

Yes you're correct. Probably my fix solved only the specific issue I was having on my project. I think the root cause of the overlapping is the implementation of findOrGenerateResponsiveLayout.

nastita commented 2 months ago

@filippo-biondi I bypassed this by making my own items positioning logic based on columns size, but Ideally I think it should be fixed in the library. I will check the implementation of that function and debug it if I find some time. I don't know if @qmhc is still maintaining the library though.