Closed SpComb closed 7 years ago
I suspect the tally:SourceState.Connected state is set incorrectly, and will always be true: https://github.com/qmsk/e2/blob/v0.4.1/tally/state.go#L131
tally:SourceState.Connected
true
I assume that the tally:Source.xmlClient will never be nil in the current implementation.
tally:Source.xmlClient
The same applies to the Source.updateState: https://github.com/qmsk/e2/blob/master/tally/source.go#L87
Source.updateState
These should either use the closed, err state set by tally:Source.run, or that func should also set xmlClient to nil.
closed
err
tally:Source.run
xmlClient
nil
I suspect the
tally:SourceState.Connectedstate is set incorrectly, and will always betrue: https://github.com/qmsk/e2/blob/v0.4.1/tally/state.go#L131I assume that the
tally:Source.xmlClientwill never be nil in the current implementation.The same applies to the
Source.updateState: https://github.com/qmsk/e2/blob/master/tally/source.go#L87These should either use the
closed,errstate set bytally:Source.run, or that func should also setxmlClienttonil.