search

qnngroup / qnngds

MIT License
5 stars 3 forks source link

update toml #84

Closed emmakbat closed 1 month ago

reed-foster commented 1 month ago

I'm not sure why none of the github actions ran on this. Looks like it's cause this is from a fork, so you're considered a first-time contributor: https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks

I'll see if I can have it run the actions.

emmakbat commented 1 month ago

Yeah, forking the repository was the recommended workflow before the refactoring. I'm not totally sure how to reset things on my machine so it's not working from the fork

reed-foster commented 1 month ago

Seems like I just need to add pull_request event for the on section of the github action: https://stackoverflow.com/questions/73314842/unable-to-trigger-github-actions-when-pull-request-comes-from-a-forked-repositor

emmakbat commented 1 month ago

Updated, and I also added a "tolerance" option to DieParameters that shrinks the pads to allow for MLA alignment error (which is inevitable, so accounting for it should be the default option)