qossmic / deprecation-detector

MIT License
390 stars 40 forks source link

Twig_Extension_GlobalsInterface usage not detected #116

Closed linaori closed 6 years ago

linaori commented 8 years ago

According to the docs, I have to implement \Twig_Extension_GlobalsInterface if I want to use getGlobals() and so I've done; class AppExtension extends \Twig_Extension implements \Twig_Extension_GlobalsInterface. However, I'm still getting this notice twice:

| 15 | Overriding deprecated method App\Extension\AppExtension->getGlobals()           | 63   | since 1.23 (to be removed in 2.0), implement Twig_Extension_GlobalsInterface instead |
| 16 | Overriding deprecated method App\Extension\AppExtension->getGlobals()           | 63   | since 1.23 (to be removed in 2.0), implement Twig_Extension_GlobalsInterface instead |

It seems like the usage is not suppressing this notice even though this is how it's supposed to be done.