search

qq99 / echoplexus

Socket.io powered chat, JavaScript REPL, whiteboard, and WebRTC calls
Other
393 stars 54 forks source link

Refactor the code #198

Open qq99 opened 10 years ago

qq99 commented 10 years ago

Just going over some of the files now, there's a lot that's stale or could be improved (at least syntactically) from the coffeescript rewrite. There's also a lot of cases where data is being sent across (room name) in the body of the message, but this isn't even necessary as it should just be inferred from the namespaced events

qq99 commented 10 years ago

Previous discussions: https://github.com/qq99/echoplexus/issues/122 https://github.com/qq99/echoplexus/issues/121

jamiees2 commented 10 years ago

Are you considering an (almost) rewrite or something else? I think we could also take a look at this, i have been using it in some personal projects and i love the added code separation it adds, while not losing alot of the core stuff from backbone.

qq99 commented 10 years ago

I've heard a lot of good thing about Marionette As for client side, it would definitely be nice to have a pretty big re-write Server code is not so messy, but client code has really exploded in complexity & has very few tests

ghost commented 10 years ago

Why not both?

On Sun, Aug 17, 2014 at 2:07 AM, Anthony Cameron notifications@github.com wrote:

I've heard a lot of good thing about Marionette As for client side, it would definitely be nice to have a pretty big re-write Server code is not so messy, but client code has really exploded in complexity & has very few tests

— Reply to this email directly or view it on GitHub https://github.com/qq99/echoplexus/issues/198#issuecomment-52409501.

qq99 commented 10 years ago

Works for me :D