search

qsbase / qs

Quick serialization of R objects
400 stars 19 forks source link

Relax the R >= 3.5 requirement #11

Closed gaborcsardi closed 5 years ago

gaborcsardi commented 5 years ago

What would it take to support R >= 3.2?

traversc commented 5 years ago

Just deleting the alt-rep stuff. I'm using it because I think the string cache is unnecessarily slow, but someone else pointed out that it can blow up memory.

gaborcsardi commented 5 years ago

What do you think about having an ALTREP free implementation for older R versions?

On Wed, 10 Jul 2019, 19:02 Travers, notifications@github.com wrote:

Just deleting the alt-rep stuff. I'm using it because I think the string cache is unnecessarily slow, but someone else pointed out that it can blow up memory.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/traversc/qs/issues/11?email_source=notifications&email_token=AAFBGQG6X3PIMKKXKXWW4XLP6YIZFA5CNFSM4H7PHFF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZUDJFI#issuecomment-510145685, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFBGQE4PMFISMDKSGIISADP6YIZFANCNFSM4H7PHFFQ .

traversc commented 5 years ago

Hi Gabor, I updated the github version so that it works with R < 3.5. Instead of having two different versions, I used preprocessor macros to comment out alt-rep stuff if it detects R < 3.5.

Tested it out with R 3.4 on windows.

gaborcsardi commented 5 years ago

Thanks!