search

quantifyearth / shark

3 stars 1 forks source link

Allow default path for containers to be set in frontmatter #55

Closed mdales closed 2 months ago

mdales commented 2 months ago

As a quick way to save my sanity with the TMF. We have a hardcoded default path in containers of "/root" this change lets you override that in front matter.

Currently it's overridden for all containers with the same value, and I suspect we need it to be per container name. But for now this is a minimal change to stop me starting every block in the TMF runorder.md with a change directory command.

patricoferris commented 2 months ago

Would it be better to implement the same docker logic that remembers where the containers last working dir was?

mdales commented 2 months ago

@patricoferris yeah, I think that'd be good - I just wasn't sure how easy it'd be to bounce that around with the saved containers

patricoferris commented 2 months ago

Cool I might look into it https://github.com/ocurrent/obuilder/issues/182