search

quaquel / EMAworkbench

workbench for performing exploratory modeling and analysis
BSD 3-Clause "New" or "Revised" License
128 stars 90 forks source link

Speed up of plot_discrete_cdfs by 2 orders of magnitude #306

Closed quaquel closed 1 year ago

quaquel commented 1 year ago

This pull request does 3 things

  1. adds a regional sensitivity analysis example
  2. speed up of plot_discrete_cdfs by 2 orders of magnitude
  3. bugfix in plot_cdfs for handling scenario_id, policy, and model

Closes #298

coveralls commented 1 year ago

Coverage Status

coverage: 80.798% (-0.1%) from 80.893% when pulling 8060660e4673a36fe4df5f2a80da8b38c14e3bdd on regional_sa into 81a1f499ae314f50849a9b78fcf4eb0dbd14e250 on master.

EwoutH commented 1 year ago

Thanks, will review later this week.

Is this in any way breaking for current users / workflows?

quaquel commented 1 year ago

Thanks, will review later this week.

Is this in any way breaking for current users / workflows?

this change won't break anything major because it is just a visual change.

EwoutH commented 1 year ago

Before this PR: 278872579-4a3ac6d3-b99c-4f42-a1f7-e3b4fbc6e3e9 After this PR: Screenshot_209

Goes from 345 seconds to 2.

And looking at the CI test times, it goes from 8 to 10 minutes to around 3 minutes.

Great work!

EwoutH commented 1 year ago

Could you make the PR title more descriptive (for the changelog) and then feel free to (squash and) merge.