quaquel / EMAworkbench

workbench for performing exploratory modeling and analysis
BSD 3-Clause "New" or "Revised" License
128 stars 90 forks source link

fixes a bug where binomtest fails because of floating point math #315

Closed quaquel closed 1 year ago

quaquel commented 1 year ago

see #312

note: had to change the precommit yaml, because the 23.11.0 fails for me

-   repo: https://github.com/psf/black
    rev: 23.10.1
    hooks:
      - id: black-jupyter
EwoutH commented 1 year ago

Looks good, do we need new/updated tests?

And what's happening with Black?

quaquel commented 1 year ago

I'll fix the tests later today (need to do a few other things first)

black error in GitHub

An error has occurred: InvalidManifestError: 
==> File /Users/jhkwakkel/.cache/pre-commit/repoj1wpzd6z/.pre-commit-hooks.yaml
==> At Hook(id='black')
==> At key: stages
==> At index 0
=====> Expected one of commit, commit-msg, manual, merge-commit, post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg, push but got: 'pre-commit'
Check the log at /Users/jhkwakkel/.cache/pre-commit/pre-commit.log

switching back from 23.11.0 to 23.10.1 solves this message.

EwoutH commented 1 year ago

I find the black part weird, because #309, which updated black to 2023.11.0, was merged two days ago and the CI passes on every run.

quaquel commented 1 year ago

I'll also try to look into it a bit later today. A quick search so far has not yielded any results

EwoutH commented 1 year ago

@inagege could you test if this fixes the bug for you? You can install this branch of the workbench with:

pip install -U -e git+https://github.com/quaquel/EMAworkbench@prim_bug#egg=ema-workbench
inagege commented 1 year ago

@EwoutH I did a few tests, and it worked each time, that is great

coveralls commented 1 year ago

Coverage Status

coverage: 80.575% (-0.01%) from 80.585% when pulling 4220248387de5af441382247515dcea5b265c74a on prim_bug into 2cfca39a1962bf044ef94d171f44c74d18840bc7 on master.