search

quarkiverse / quarkus-bon-jova-rockstar

An implementation of Rockstar as a JVM language
https://codewithrockstar.com/
3 stars 2 forks source link

WordCounter test failing (lyrics on server changed?) #90

Open holly-cummins opened 9 months ago

holly-cummins commented 9 months ago

I'm seeing persistent failures on the CI and locally in the word counter test.

I added a sort to the comparison in #89, to eliminate any non-determinism in the map order, but it looks like abusin has disappeared?

org.opentest4j.AssertionFailedError: 
Expected :{about=1, abusin=1, aiai=1, another=1, away=1, back=35, bang=1, beatin=1, been=2, black=7, blue=1, bluest=1, break=1, bright=1, bullet=1, cadillac=1, catch=1, cats=1, cause=4, child=7, childhood=1, chorus=1, chorus:=1, dont=1, down=1, every=1, everyt ...

Actual   :{about=1, aiai=1, another=1, away=1, back=43, bang=1, been=1, black=9, blue=1, bluest=1, break=1, bright=1, bullet=1, cadillac=1, catch=1, cats=1, cause=5, child=7, childhood=1, dont=1, down=1, every=1, everything=1, eyes=3, face=1, forget=1, fresh=1 ...
hannotify commented 9 months ago

Now that lyrics are downloaded from multiple different sources, these tests have become very brittle. Because tiny variations in lyrics exist across these different sources, we can't be sure any more what the exact output should be. Let's disable these tests until we can find a better solution.