Closed Fenrisfulsur closed 6 months ago
Thanks for the contribution, I just changed two things:
if TYPE_CHECKING
condition. This has not been enforced on the entire code base yet but let's try to avoid this practice on the new codeWrap the casting from capstone group into a specific method, this should help for code reuse and it can centralize the conversion from capstone into a single place. If in the future we will have misalignment issues it will be easier to address them.
Beside this LGTM!
Fix the JumpNb feature by replacing mnemonic check with capstone group check