quarkusio / quarkus-github-bot

A Quarkus-powered GitHub App to simplify issues and pull requests management in the Quarkus project.
Apache License 2.0
24 stars 25 forks source link

Extend auto-triage/mention feature to failing builds in e.g. quickstarts #451

Open yrodiere opened 4 months ago

yrodiere commented 4 months ago

Right now when one make a change to Quarkus, they may inadvertently break the Quickstarts. It's generally easy to solve, but hard to spot, because it's hard to get properly notified about these failures.

For example I mainly work on Hibernate extensions on Quarkus. If I wanted to get notified when Hibernate quickstart builds start failing, my only option would be to subscribe to this issue, and then I'll be notified for every single quickstart failure, including those for the (many) extensions unrelated to Hibernate.

Solution proposal

In the bot, we already have code that:

We could imagine that, on Quickstart build failures, the Quarkus bot, or an action, would analyze the build result, group propblems them by quickstart or relevant extension, then would provide a detailed report on the dedicated issue, and @mention the people responsible for these quickstarts or the relevant extensions.

rsvoboda commented 4 months ago

We have Quickstarts compilation check in our Quarkus CI - https://github.com/quarkusio/quarkus/blob/main/.github/workflows/ci-actions-incremental.yml#L853

Tests were skipped to save CI capacity, maybe we can reconsider that decision. wdyt?

yrodiere commented 4 months ago

Tests were skipped to save CI capacity, maybe we can reconsider that decision. wdyt?

No opinion on resource usage, but it may not be strictly necessary. We'll need a way to detect compilation failures and assign them to the right people anyway.