quarkusio / quarkus-quickstarts

Quarkus quickstart code
https://quarkus.io
Apache License 2.0
1.95k stars 1.45k forks source link

Fix spring-data-rest quickstart as spring-data-rest extension move to SB3 #1427

Closed jedla97 closed 3 months ago

jedla97 commented 3 months ago

As spring-data-rest extension was moved to Spring Boot 3 the quickstart spring-data-rest quickstart no longer work. Caused by PagingAndSortingRepository no longer extend CrudRepository. The guide show the usage of CrudRepository, which working.

Otherwise if you want I can adapt it to

public interface FruitsRepository extends JpaRepository<Fruit, Long> {
}

or

public interface FruitsRepository extends PagingAndSortingRepository<Fruit, Long>, CrudRepository<Fruit, Long> {
}

The JpaRepository extend the CrudRepository and PagingAndSortingRepository stop extending the CrudRepository.

I don't have strong preferences about this.

Check list:

Your pull request:

geoand commented 3 months ago

cc @aureamunoz

quarkus-bot[bot] commented 3 months ago

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit e0ff62e3f56572c463104f5cf95e79af5ae4ae9c.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Failures

:gear: Build - JDK 17 #

- Failing: optaplanner-quickstart 

:package: optaplanner-quickstart

Failed to execute goal on project optaplanner-quickstart: Could not resolve dependencies for project org.acme:optaplanner-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-webjars-locator:jar:999-SNAPSHOT

geoand commented 3 months ago

@gsmet is the failure above expected?

jedla97 commented 3 months ago

@geoand I look at the failiure (can't say it's expected as I don't know how Quarkus falling back when rename of package happened) but the webjars-locator was renamed migration guide

Created PR https://github.com/quarkusio/quarkus-quickstarts/pull/1428 for it as it would happen in future