Open rsvoboda opened 4 years ago
@gsmet fyi
PostgreSQL container is not stopped because of this and breaks other QS execution.
In my case it caused failures of https://github.com/quarkusio/quarkus-quickstarts/blob/master/security-jdbc-quickstart/src/test/java/org/acme/elytron/security/jdbc/JdbcSecurityRealmTest.java#L25 (I use -fae
for maven command)
Regarding the leftover PostgreSQL container:
whenever testcontainers starts up a container, by default it will add that container to be automatically cleaned up in a JVM shutdown hook I think the only reason the container is left around in this case is because the JVM is crashing and shutdown hooks aren't running. Normally this wouldn't conflict with subsequent runs because by default testcontainers selects a random port on the host to use. But in this quickstart they always bind to 5432 specifically. The quickstart could be updated to use the default randomized ports, but it's probably more important to fix the JVM crash first.
/cc @yrodiere any chance we could use a GC supported by GraalVM out of the box?
@gsmet Totally. We can customize jvm options easily. In fact we already do: https://github.com/quarkusio/quarkus-quickstarts/blob/master/hibernate-search-elasticsearch-quickstart/src/test/resources/elasticsearch-maven-plugin/configuration/jvm.options#L39
Ideally, I'd prefer using a separate JVM for Elasticsearch, as I don't think the Elasticsearch team supports running ES on GraalVM. That can be done with elasticsearch-maven-plugin, but it will make the Maven configuration more complex which probably is something you'll want to avoid in a quickstart.
Can't we just use a container instead of elasticsearch-maven-plugin? Since we already do that for postgreSQL? If I had some free time to set it up, and if I wasn't forced to support ES versions that don't have a standard, usable container available (ES 5.6), that's totally what I would do in the Hibernate Search build.
hibernate-search-elasticsearch-quickstart QS fails with GraalVM 19.3.1 in JVM mode It didn't fail when I used OpenJDK 8 and 11.
elasticsearch-maven-plugin:6.15:runforked
phase is failing.Reproducer:
Longer version from console: