search

quarkusio / quarkus-workshops

Hosts Quarkus related workshops
https://quarkus.io/quarkus-workshops/super-heroes/
Apache License 2.0
177 stars 175 forks source link

Replace Maven plugin commands with Quarkus CLI #602

Open gastaldi opened 1 week ago

gastaldi commented 1 week ago

Windows environments are not that friendly when using double quotes (") with the ./mvnw command and I have seen that it also complains about JAVA_HOME not being set when using PowerShell.

Replacing all ./mvnw commands with the Quarkus CLI respective command would be nice. Besides being cleaner, it generally works in the environment described above.

holly-cummins commented 6 days ago

The downside of that is that it's an extra setup step for workshop participants. One goal of the workshop is close-to-zero setup. Sometimes it's taken people half the workshop to install prereqs on their laptop (when we had more). Baffling, but true.

On the other hand, another goal of the workshop is to work on windows. I wonder if we could refine the commands for windows to get ones that work reliably? We do have the option to have specific commands for windows users, so we can adjust as needed without worrying about windows and mac.

gastaldi commented 6 days ago

@holly-cummins True, but in my humble experience during the development of a Quarkus app, I find it way easier to use the Quarkus CLI than to remember the syntax for the Maven plugin. Even if this is an extra configuration step, I believe we should be promoting the CLI usage instead of forcing users to use the plugins directly.

As an idea, if the step is still optional, perhaps we could display in a tab-like component the command to be run using the Maven plugin with the CLI in a separate tab for users (like me) who prefer the CLI instead.

Also, the most frustrating experience is to have a mvnw command failing with an unexpected output, which is something we can better control when using the CLI