Further improvements to Kafka Streams extension

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.

https://quarkus.io

Apache License 2.0

13.84k stars 2.7k forks source link

Further improvements to Kafka Streams extension #3500

Open gunnarmorling opened 5 years ago

gunnarmorling commented 5 years ago

Follows up on #2863.

[ ] Auto-register the default key and value SerDes for reflection (see https://github.com/quarkusio/quarkus/issues/3202)
[ ] Auto-register types for reflection that are de-serialized by Serdes used in the pipeline
[ ] Export a healthcheck based on the state of the KafkaStreams object
[ ] Export metrics based on the metrics of the KafkaStreams object
[ ] Default quarkus.kafka-streams.application-id to quarkus.application.name

@gsmet, can you assign this to me?

muirandy commented 5 years ago

@gunnarmorling Will this override the need for #3202 ?

gunnarmorling commented 5 years ago

Hey @muirandy, good question; essentially the first bullet ("Auto-register the default key and value SerDes for reflection") captures the same requirement as #3202. Now that my work on #2863 has been merged into master, you'd actually be in a good position to file a PR for tackling this, if you're still interested. IIRC, you had the actual work done already, so perhaps all that's needed is to rebase yourwork to master and send a PR?

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you! We are doing this automatically to ensure out-of-date issues does not stay around indefinitely. If you believe this issue is still relevant please put a comment on it on why and if it truly needs to stay request or add 'pinned' label.

belfo commented 4 years ago

@gunnarmorling any update? I'm especially interessed in having the kakfa stream metrics when using a produce method. As stated in #5471 it's not possible to access the underling object to manually get the metrics (as explained here: https://quarkus.io/blog/kafka-streams-applications-with-quarkus-and-microprofile/)