feat: eslint-plugin-vue & stylelint & more

beeplin commented 7 years ago

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[x] Yes
[ ] No

If yes, please describe the impact and migration path for existing applications:

This PR adds more linting rules for vue files (in templates, scripts and styles), and this may make some old user codes cannot pass building -- which is exactly what linting is designed for. But all the rules can be turned off easily, and most people just use this new pwa template to initiate new projects, so this might not be a REAL breaking change.

The PR fulfills these requirements:

[ ] It's submitted to the dev branch and not the master branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
[x] It's been tested with all Quasar themes
[ ] It's been tested on a Cordova (iOS, Android) app
[ ] It's been tested on a Electron app
[ ] Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

[x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

eslint-plugin-vue

see https://github.com/vuejs/eslint-plugin-vue

stylelint for vue files

see https://github.com/stylelint/stylelint and https://github.com/vuejs/vue-loader/issues/303

babel-preset-env

replacing babel-preset-es2015, see http://babeljs.io/docs/plugins/#presets-official-presets

postcss-loader v2

just add an empty config file to enable v2

webpack-bulder-analyzer

nice bundle size viewer. to enable: npm run build --report

beeplin commented 7 years ago

@rstoenescu this is the PR I mentioned in #5

rstoenescu commented 6 years ago

Very good PR, don't know how I missed it. Will get it into the v0.15 starter kit. Thanks for your efforts!

beeplin commented 6 years ago

@rstoenescu Most features in this PR has been integrated in quasar 0.15, so I am closing it.

v0.15 is amazing~!

quasarframework / quasar-template-pwa