search

quatrope / ProperImage

Proper Image utils for astronomy.
BSD 3-Clause "New" or "Revised" License
26 stars 6 forks source link

pickle import #68

Open martinberoiz opened 4 years ago

martinberoiz commented 4 years ago

If I understand correctly, apparently since python 3.0 pickle/cpickle is just pickle.

A common pattern in Python 2.x is to have one version of a module implemented in pure Python, with an optional accelerated version implemented as a C extension; for example, pickle and cPickle. This places the burden of importing the accelerated version and falling back on the pure Python version on each user of these modules. In Python 3.0, the accelerated versions are considered implementation details of the pure Python versions. Users should always import the standard version, which attempts to import the accelerated version and falls back to the pure Python version. The pickle / cPickle pair received this treatment.

So these lines

https://github.com/quatrope/ProperImage/blob/44a3af6f17c41739077adb9fca646e29cbe0e4ca/properimage/operations.py#L37-L40

Should be just

import pickle