Closed ahmed-tarek-salem closed 1 month ago
Latest updates from Figma are missing as discussed in Discord
@sallymoc
Done, please check.
@ahmed-tarek-salem please adjust the scanner view as indicated in Figma
@ahmed-tarek-salem Also, as discussed in Discord, please add confirmation messages for the disconnect action:
Disconnect "
Disconnect all the apps? Disconnecting the apps will remove all access to your wallet
Buttons: Cancel / Disconnect
@ahmed-tarek-salem The snackbar message pointed with the arrow is redundant and not needed (that screen already indicates there was a successfull scan). Please remove
Please @ahmed-tarek-salem see also the Figma updates here
Also, @ahmed-tarek-salem please ensure the WC functionality is always available (to remove any previous dependency with the enable/disable switch that was in settings in previous versions)
Please @ahmed-tarek-salem also fix the layout for bigger screens here
@ahmed-tarek-salem The snackbar message pointed with the arrow is redundant and not needed (that screen already indicates there was a successfull scan). Please remove
There is a difference.
This snack bar appears immediately after detecting a proper QR code; it may or may not take some time to load before showing the new success screen.
If the loader (that appears on the Paste URL button) is enough to indicate to the user that a QR code has been detected, then we can safely remove that snack bar.
Also, @ahmed-tarek-salem please ensure the WC functionality is always available (to remove any previous dependency with the enable/disable switch that was in settings in previous versions)
Resolved
Please @ahmed-tarek-salem also fix the layout for bigger screens here
Resolved
@ahmed-tarek-salem Also, as discussed in Discord, please add confirmation messages for the disconnect action:
Disconnect ""? Disconnecting this app will remove all access to your wallet
Disconnect all the apps? Disconnecting the apps will remove all access to your wallet
Buttons: Cancel / Disconnect
Text for title and cancel button text doesn't match with the requirement in the current implementation
@ahmed-tarek-salem The snackbar message pointed with the arrow is redundant and not needed (that screen already indicates there was a successfull scan). Please remove
There is a difference.
This snack bar appears immediately after detecting a proper QR code; it may or may not take some time to load before showing the new success screen.
If the loader (that appears on the Paste URL button) is enough to indicate to the user that a QR code has been detected, then we can safely remove that snack bar.
Yes, the loading indicator + the screen user's interaction disabled it's good enough for this @ahmed-tarek-salem
@ahmed-tarek-salem Also, as discussed in Discord, please add confirmation messages for the disconnect action: Disconnect ""? Disconnecting this app will remove all access to your wallet Disconnect all the apps? Disconnecting the apps will remove all access to your wallet Buttons: Cancel / Disconnect
Text for title and cancel button text doesn't match with the requirement in the current implementation
Resolved, removed unused IdListItem code, and added a shared ConfirmationDialog.
@ahmed-tarek-salem The snackbar message pointed with the arrow is redundant and not needed (that screen already indicates there was a successfull scan). Please remove
There is a difference. This snack bar appears immediately after detecting a proper QR code; it may or may not take some time to load before showing the new success screen. If the loader (that appears on the Paste URL button) is enough to indicate to the user that a QR code has been detected, then we can safely remove that snack bar.
Yes, the loading indicator + the screen user's interaction disabled it's good enough for this @ahmed-tarek-salem
Resolved.
Please resolve the conflicts
@sallymoc Done
Changes